Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkite/interpolate updated; ability to use numeric default #1217

Merged
merged 1 commit into from
May 28, 2020

Conversation

pda
Copy link
Member

@pda pda commented May 26, 2020

Update buildkite/interpolate to get buildkite/interpolate#7 /cc @ticky

${VAR:-127} will now resolve to 127 if VAR isn't set.

Delta commit log on buildkite/interpolate:

*   07f35b4 Merge pull request #7 from buildkite/bash-compliant-substring-parsing Jessica Stokes 2 hours ago
|\
| * 24225d9 Update substring parser to comply with Bash's rules Jessica Stokes 10 days ago
|/
* 973457f Add an empty go.mod file Lachlan Donald 1 year, 7 months ago
* cfbed48 Update README to reflect current code Lachlan Donald 1 year, 7 months ago
* c1c376f Merge pull request #4 from buildkite/expose-identifiers-from-parse-tree Lachlan Donald 2 years, 3 months ago
* ad3fc26 Add a interpolate.Identifiers() for getting identifiers from a string Lachlan Donald 2 years, 3 months ago

    ${VAR:-127} will now resolve to "127" if VAR isn't set.

Commit log on buildkite/interpolate:

    *   07f35b4 Merge pull request #7 from buildkite/bash-compliant-substring-parsing Jessica Stokes 2 hours ago
    |\
    | * 24225d9 Update substring parser to comply with Bash's rules Jessica Stokes 10 days ago
    |/
    * 973457f Add an empty go.mod file Lachlan Donald 1 year, 7 months ago
    * cfbed48 Update README to reflect current code Lachlan Donald 1 year, 7 months ago
    * c1c376f Merge pull request #4 from buildkite/expose-identifiers-from-parse-tree Lachlan Donald 2 years, 3 months ago
    * ad3fc26 Add a interpolate.Identifiers() for getting identifiers from a string Lachlan Donald 2 years, 3 months ago
@pda pda requested a review from ticky May 26, 2020 02:39
@ticky
Copy link
Contributor

ticky commented May 26, 2020

Out of curiosity, what was the correct incantation to sync this? Or did you manually copy the SHA?

Copy link
Contributor

@ticky ticky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pda
Copy link
Member Author

pda commented May 28, 2020

Out of curiosity, what was the correct incantation to sync this? Or did you manually copy the SHA?

@ticky I ran go get -u github.com/buildkite/interpolate in the project, which fetched the latest version and updated go.mod and added the new checksum to go.sum. I don't think the -u was necessary.

@pda pda merged commit a5cf4b8 into master May 28, 2020
@pda pda deleted the update-interpolate-module branch May 28, 2020 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants