agent/form_uploader: Implement HTTP Request debug #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This completes the implementation of the `DebugHTTP` option, which we describe as "dumps all request and response bodies to the log". It previously did not dump request bodies made by the form_uploader, only their responses. Implementation borrowed from `api/client`, which already handled this similarly.
keithpitt
reviewed
Jan 22, 2020
| requestDump, err = httputil.DumpRequestOut(request, true) | ||
| } | ||
|
|
||
| u.logger.Debug("\nERR: %s\n%s", err, string(requestDump)) |
There was a problem hiding this comment.
Is this log output in the right order? Should we be showing the request dump first then the error? Or is this how the other places do it?
There was a problem hiding this comment.
It’s the same order as the other instance in this file:
Lines 88 to 91 in f998329
keithpitt
approved these changes
Jan 22, 2020
keithpitt
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the implementation of the
DebugHTTPoption, which we describe as "dumps all request and response bodies to the log".It previously did not dump request bodies made by the form_uploader, only their responses.
Implementation borrowed from
api/client, which already handled this similarly.