Added feature to enable encryption at rest for artifacts in S3. #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a new ENV variable BUILDKITE_S3_SSE_ENABLED in line with the existing enviroment variables. Currently validate of this value is optimised for feedback, being limited to covering the case of encryption at rest. If this accepted the full range of options supported by S3 it would be difficult to validate as it requires a how load of KMS infrastructure and permissions. Also extracted the existing flag and wrote some tests for it and the new option.
jradtilbrook
approved these changes
Aug 14, 2019
|
This looks good to me! |
|
Thanks @wolfeidau! |
|
@lox are you able to provide a timeframe you think you'll be able to cut a new release including this change? |
|
I'll try and get one out tomorrow! |
|
Shipped a release last week! https://github.com/buildkite/agent/releases/tag/v3.14.0 |
|
Awesome thanks! I'll try it out later this week hopefully |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a new ENV variable BUILDKITE_S3_SSE_ENABLED in line with the
existing enviroment variables.
Currently validate of this value is optimised for feedback, being limited
to covering the case of encryption at rest. If this accepted the full
range of options supported by S3 it would be difficult to validate
as it requires a how load of KMS infrastructure and permissions.
Also extracted the existing flag and wrote some tests for it and the new
option.