Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote command to git submodule foreach #1029

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

lox
Copy link
Contributor

@lox lox commented Jun 12, 2019

It appears that git 2.19.0 dropped support for multiple arguments to git submodule foreach.

I can't find an exact reference in the release notes, but in 2.18.0 the following worked:

git submodule foreach --recursive git reset hard

Now it needs to be:

git submodule foreach --recursive 'git reset hard'

The docs indicate it has a single , so perhaps this was undocumented behaviour?

Closes #1028.

It appears that git 2.19.0 dropped support for multiple arguments to git
submodule foreach.
@lox lox requested a review from a team June 12, 2019 03:19
@lox lox merged commit 6e0ab0b into master Jun 12, 2019
@lox lox deleted the ensure-git-submodule-foreach-commands-are-quoted branch June 12, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing quotes in git submodule foreach
1 participant