removeOnBreadcrumbBlock not working from swift

[hovox]

Hi Bugsnag team,

We have tried to use removeOnBreadcrumbBlock from swift and find out that is not deleting the block.

Here is the code examples which we have tried:

// passing as function like mentioned in the documentation
func cb(breadcrumb: BugsnagBreadcrumb) -> Bool { /* ... */ }
Bugsnag.addOnBreadcrumb(block: cb)
// ...
Bugsnag.removeOnBreadcrumb(block: cb)

// passing as @convention(block
let bl:@convention(block) (_ breadcrumb: BugsnagBreadcrumb) -> Bool =
Bugsnag.addOnBreadcrumb(block: cb)
// ...
Bugsnag.removeOnBreadcrumb(block: cb)

and some other variations , we have tried to remove copy call in the addOnBreadcrumb and nothing helped.

Then in the new project we have tried to reproduce the issue, we have found out that when we are changing addOnBreadcrumb/removeOnBreadcrumb to + (void)removeOnBreadcrumbBlock:(id)block,+ (void)addOnBreadcrumbBlock:(id)block (type is id) it started working. Then we have did a workaround by declaring an extension on the Bugsnag class:

 + (void)addOnBreadcrumbAnyTypeBlock:(id)block {
     [self addOnBreadcrumbBlock:block];
 }

 + (void)removeOnBreadcrumbAnyTypeBlock:(id)block {
     [self removeOnBreadcrumbBlock:block];
 }

 @end

when we call `addOnBreadcrumbAnyTypeBlock/removeOnBreadcrumbAnyTypeBlock from swift it correctly adds/removes.

[luke-belton]

Hi @hovox - thanks for raising this. We've managed to reproduce this and we're going to look into it further. We'll keep you updated on this thread!

[yousif-bugsnag]

This is now fixed in v6.15.0 🎉