Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy instead of move #3

Open
vinjana opened this issue Jan 13, 2022 · 0 comments
Open

Copy instead of move #3

vinjana opened this issue Jan 13, 2022 · 0 comments

Comments

@vinjana
Copy link

vinjana commented Jan 13, 2022

It would be better to have a virtualenv-cp than virtualenv-mv:

  • This would simplify the implementation, because no "backup and restore original" logic is necessary.
  • Currently, the backup is written close to the source -- a path that may not be writable (it's not for me).
  • Move = Copy + Delete -- so copy is more modular. Also, delete is trivial. Furthermore, deletion hurts, if its impossible because of lacking permissions on the source.
  • Not that this would be a big issue, but on our NFS the copying of a venv takes quite some time. Doing a backup is unnecessary and thus removing it would also make the script faster.

The only thing that seems to be argument for virtualenv-mv is that the moving the environment is often what people want to do. Why not make a simplified virtualenv-cp and implement virtualenv-mv in terms of virtualenv-cp + delete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant