Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random behavior from test factories #119

Open
ericfreese opened this issue Apr 27, 2017 · 0 comments
Open

Remove random behavior from test factories #119

ericfreese opened this issue Apr 27, 2017 · 0 comments
Labels

Comments

@ericfreese
Copy link
Member

Lots of factories have random behavior, which is a recipe for flaky tests. We saw this recently with the spec added in #112. The flaky behavior was traced to a factory that would sometimes add zero associated objects and fixed in #116.

We should update factories one by one to remove all random behavior so that we can depend on stable data for our tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant