Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: [deps] Platform: Update azure azure-sdk-for-net monorepo #5447

Merged

Conversation

ike-kottlowski
Copy link
Contributor

@ike-kottlowski ike-kottlowski commented Feb 26, 2025

🎟️ Tracking

This reverts commit 492a3d6.

📔 Objective

Azurite Blobs is incompatible with integration tests causing server failures. Working with @justindbaur to figure out how to avoid this error in the future.

Related: Azure/Azurite#2532

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@ike-kottlowski ike-kottlowski enabled auto-merge (squash) February 26, 2025 14:43
@ike-kottlowski ike-kottlowski merged commit dd78361 into main Feb 26, 2025
45 checks passed
@ike-kottlowski ike-kottlowski deleted the renovate/revert-azure-azure-sdk-for-net-monorepo branch February 26, 2025 14:44
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details0ed8dcd6-cbdd-4d9c-98c6-2841685cdf94

New Issues (21)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Api/Platform/Push/Controllers/PushController.cs: 76
detailsMethod SendAsync at line 76 of /src/Api/Platform/Push/Controllers/PushController.cs gets user input from element model. This element’s value flows ...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/RecoveryController.cs: 38
detailsMethod ProcessEventsAsync at line 38 of /src/Billing/Controllers/RecoveryController.cs gets user input from element requestBody. This element’s val...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
LOW Log_Forging /src/Billing/Controllers/StripeController.cs: 164
detailsMethod TryParseEventFromRequestBodyAsync at line 164 of /src/Billing/Controllers/StripeController.cs gets user input from element Body. This elemen...
Attack Vector
Fixed Issues (12)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
MEDIUM CSRF /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70
LOW Log_Forging /src/Billing/Controllers/PayPalController.cs: 70

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.52%. Comparing base (492a3d6) to head (7bded9b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5447   +/-   ##
=======================================
  Coverage   44.52%   44.52%           
=======================================
  Files        1514     1514           
  Lines       70403    70403           
  Branches     6352     6352           
=======================================
  Hits        31347    31347           
  Misses      37708    37708           
  Partials     1348     1348           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants