[PM-5872] Credit load intermittently fails #5424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (26)Checkmarx found the following issues in this Pull Request
Fixed Issues (8)Great job! The following issues were fixed in this Pull Request
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5424 +/- ##
=======================================
Coverage 44.50% 44.50%
=======================================
Files 1507 1507
Lines 70024 70024
Branches 6303 6303
=======================================
Hits 31161 31161
Misses 37530 37530
Partials 1333 1333 ☔ View full report in Codecov by Sentry. |
amorask-bitwarden
approved these changes
Feb 20, 2025
| @@ -0,0 +1,7 @@ | |||
| namespace Bit.Billing.Constants; | |||
|
|
|||
| public static class BitPayInvoiceStatus | |||
There was a problem hiding this comment.
⛏️ Do you mind consolidating these in a single file called BitPayConstants the same way we do with StripeConstants?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-5872
📔 Objective
We were checking for the wrong invoice status, causing bitpay transactions to not be recorded.
References:
📸 Screenshots
Screen.Recording.2025-02-20.at.11.56.39.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes