[PM-18594] [RC] Hide coach marks if user has existing login items #1390
+132
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-livefront
requested review from
phil-livefront,
brant-livefront,
ezimet-livefront and
a team
as code owners
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2025.02-rc7 #1390 +/- ##
======================================================
Coverage ? 89.71%
======================================================
Files ? 757
Lines ? 47810
Branches ? 0
======================================================
Hits ? 42891
Misses ? 4919
Partials ? 0 ☔ View full report in Codecov by Sentry. |
fedemkr
reviewed
Feb 26, 2025
Comment on lines
20
to
31
| var hasLoginItems: Bool { | ||
| flatMap(\.items) | ||
| .contains { item in | ||
| if case let .group(group, count) = item.itemType, group == .login { | ||
| count > 0 // swiftlint:disable:this empty_count | ||
| } else if case let .cipher(cipherView, _) = item.itemType, cipherView.type == .login { | ||
| true | ||
| } else { | ||
| false | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🤔 I wonder if we should check .totp here as well as a TOTP item is in fact a Login item. I mean I know the goal of the PR is actually achieved with the current logic but the purpose of hasLoginItems of a vault list section should also be based given if in the section are all .totp items.
There was a problem hiding this comment.
I can include that too.
ezimet-livefront
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-18594
📔 Objective
If a user has existing login items in their vault, the coach marks for add login and in the generator should be dismissed.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes