Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/valkey] Chart with auth.usePasswordFiles: true trying to mount valkey-password even with auth.enabled: false #32154

Open
Sad-Soul-Eater opened this issue Feb 25, 2025 · 1 comment · May be fixed by #32157
Assignees
Labels
tech-issues The user has a technical issue about an application triage Triage is needed valkey

Comments

@Sad-Soul-Eater
Copy link

Sad-Soul-Eater commented Feb 25, 2025

Name and Version

bitnami/valkey 2.4.0

What architecture are you using?

amd64

What steps will reproduce the bug?

Deploy valkey chart version 2.4.0 which includes new (#32121 usePasswordFiles=true by default) changes

Are you using any custom parameters or values?

architecture: standalone
auth:
  enabled: false
global:
  defaultStorageClass: flash-iscsi
primary:
  kind: Deployment
  updateStrategy:
    type: Recreate
  resources:
    requests: { cpu: 20m, memory: 128Mi }
    limits: { memory: 256Mi }
  persistence:
    annotations:
      k8up.io/backup: "true"
    size: 512Mi
  persistentVolumeClaimRetentionPolicy:
    enabled: true
    whenDeleted: Delete

What is the expected behavior?

Do not mount non-existed valkey-password secret when auth.enabled: false

{{- if .Values.auth.usePasswordFiles }}
- name: valkey-password
{{ if .Values.auth.usePasswordFileFromSecret }}
secret:
secretName: {{ template "valkey.secretName" . }}
items:
- key: {{ template "valkey.secretPasswordKey" . }}
path: valkey-password
{{- else }}
emptyDir: {}
{{- end }}
{{- end }}

What do you see instead?

Pod cannot start because secret for valkey-password volume is not existing when auth.enabled: false

Additional information

No response

@Sad-Soul-Eater Sad-Soul-Eater added the tech-issues The user has a technical issue about an application label Feb 25, 2025
@Sad-Soul-Eater Sad-Soul-Eater changed the title [bitnami/valkey] Chart with auth.usePasswordFiles: true trying to mount valkey-secret even with auth.enabled: false [bitnami/valkey] Chart with auth.usePasswordFiles: true trying to mount valkey-password even with auth.enabled: false Feb 25, 2025
@github-actions github-actions bot added the triage Triage is needed label Feb 25, 2025
@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-issues The user has a technical issue about an application triage Triage is needed valkey
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants