Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Specify custom GitHub deployment environment #89

Merged
merged 10 commits into from
Sep 24, 2021

Conversation

rafiksargsyan
Copy link
Contributor

Currently, the only possible values for the GitHub environment are "Production" and "Preview".
Sometimes there is a need for custom environments (like Stage, Dev, etc.). This patch removes the
limitation.

@BetaHuhn
Copy link
Owner

Hey, thanks for taking the time to create this PR!

I'd prefer it if the new option is called GITHUB_DEPLOYMENT_ENV instead of DEPLOY_ENV so it's clearer what it does.

If you change that and revert the whitespace changes, I will merge it!

@rafiksargsyan
Copy link
Contributor Author

@BetaHuhn, I have done the requested changes, could you check if everything is OK.
Thanks, Rafik

@BetaHuhn BetaHuhn changed the base branch from master to develop September 24, 2021 16:48
@BetaHuhn BetaHuhn changed the title Allow users to specify custom environment for github deployments ✨ Specify custom GitHub deployment environment Sep 24, 2021
@BetaHuhn BetaHuhn merged commit 57d3a65 into BetaHuhn:develop Sep 24, 2021
@BetaHuhn
Copy link
Owner

Everything checks out, thanks!

@BetaHuhnBot
Copy link
Collaborator

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants