Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Fix example for turning off pull request labels #41

Closed
wants to merge 1 commit into from
Closed

📝 Fix example for turning off pull request labels #41

wants to merge 1 commit into from

Conversation

Siilwyn
Copy link
Contributor

@Siilwyn Siilwyn commented May 14, 2021

The value of PR_LABELS is an array, false results in a label with the text 'false' being used.

The value of `PR_LABELS` is an array, `false` results in a label with the text 'false' being used.
@Siilwyn
Copy link
Contributor Author

Siilwyn commented May 14, 2021

Also thank you for this great GH action!

@BetaHuhn
Copy link
Owner

BetaHuhn commented May 14, 2021

Hey, thanks for taking the time to create this PR!

This actually appears to be a bug in how the inputs get parsed. It should disable the labels input when it's set to false instead of using that as a value.

I recently created a new library which simplifies the parsing of inputs in GitHub Actions called action-input-parser, but I haven't had the time to refactor this Action to use it. The library would fix this issue.

I am going to close this PR in favor of refactoring the input parsing. @Siilwyn if you want, you can create a new PR which uses the new library, or wait for me to do it this weekend.

@BetaHuhn BetaHuhn closed this May 14, 2021
@BetaHuhn BetaHuhn added the bug Something isn't working label May 14, 2021
@Siilwyn Siilwyn deleted the patch-1 branch May 14, 2021 12:35
BetaHuhn added a commit that referenced this pull request May 15, 2021
@BetaHuhnBot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.3.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants