flag suggestions like --verbose get triggered by two dashes --, but insert four ----

[j-lakeman]

Code editor

Visual Studio Code

Platform

Linux

Version

v1.36.0

What steps will reproduce the bug?

Insert a command that has the --verbose flag, like rsync, for example. Continue typing --v, until the autocompletion offers --version and --verbose. Pick either one from the menu. Two additional dashes get inserted, so that there are four altogether.

How often does it reproduce? Is there a required condition?

reproduces for any -- flags

What is the expected behavior?

don't insert additional dashes

What do you see instead?

Two additional dashes get inserted, so that there are four altogether.
This is unintended behaviour.

Additional information

video.webm

[skovhus]

Thanks for reporting this!

A fix for this was released in the vscode extension version 1.37.0.

[j-lakeman]

Cheers, seems resolved! But I'm experiencing another issue now. The first letter of the accepted flag gets removed, see video below:

video.webm

[lxr2010]

Cheers, seems resolved! But I'm experiencing another issue now. The first letter of the accepted flag gets removed, see video below:

video.webm

I'm using nvim.cmp and bash-language-server, also have this problem.
It seems that nvim.cmp deals with "insertText" field differently from VS code client.
I tried to describe insertion with "textEdit" instead of "insertText" , recompiled and reinstalled bash-language-server, and the problem solved.