Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Allow to configure glob options #316

Closed
loynoir opened this issue Nov 20, 2021 · 1 comment
Closed

[FeatureRequest] Allow to configure glob options #316

loynoir opened this issue Nov 20, 2021 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@loynoir
Copy link

loynoir commented Nov 20, 2021

Feature Request

Would be nice to be able to configure glob options. 😄

{ cwd: rootPath, nodir: true, absolute: true, strict: false },

Use case

For example, glob options follow: true.

I use pnpm to manage shell dependency to avoid doppelgangers. 😄

But, pnpm use symlink...

Alternative

Glob here is about sourcing files, existing sourcing file pattern allowed by shellcheck.

# src/foo.sh

# shellcheck source-path=../node_modules/MODULE_NAME
BASE=/path/to/node_modules/MODULE_NAME
source "${BASE}"/lib/bar1.sh
source "${BASE}"/lib/bar2.sh
...

Maybe when found syntax

source ${VARIABLE}/SUBPATH

Let bashls source

path.join(
  path.resolve(
    path.dirname(CURRENTFILE), 
    SHELLCHECK_SOURCE_PATH_ELEMENT
  ),
  SUBPATH
)
@skovhus skovhus added enhancement New feature or request priority ⭐️ Triaged and deemed a priority labels Nov 25, 2022
@skovhus
Copy link
Collaborator

skovhus commented Nov 28, 2022

A more performant, robust and stable analyzer has been released as version 3.3.0 (which is part of the latest VSCode extension 1.17.0). You can find more details in #569

I'm very curious if you can test it out and see how it works for you. We do not allow the glob options to be configured yet.

#244 could improve how we do scope aware completions based on sourced files.

Thanks in advance :)

@skovhus skovhus added question Further information is requested and removed priority ⭐️ Triaged and deemed a priority labels Nov 28, 2022
@skovhus skovhus closed this as completed Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants