Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCM improvements/partial refactoring #366

Open
dominikbach opened this issue Apr 13, 2022 · 0 comments · Fixed by #368
Open

DCM improvements/partial refactoring #366

dominikbach opened this issue Apr 13, 2022 · 0 comments · Fixed by #368
Assignees
@teddychao
Labels
Conceptional The pull request includes conceptional updates

Comments

@dominikbach
Copy link
Contributor

dominikbach commented Apr 13, 2022 •
edited
Loading

General

DCM code has become impenetrable. The implementation of NaN processing has generated a string of bug reports and bug fixes. Here are some ideas how to facilitate debugging and some partial refactoring. This list is work in progress.

Debugging

  1. Save the original input data in the model, rather than just the subsession data (similar to dcm.input.timing). Currently the data are stored by: model.scr = sbs_data(proc_subsessions);. This could be complemented by something like model.raw_scr = data;

Refactoring
@teddychao teddychao self-assigned this Apr 18, 2022
@teddychao teddychao linked a pull request Apr 25, 2022 that will close this issue
Fix issue 366 - pspm_dcm #368
Merged
@teddychao teddychao mentioned this issue Apr 25, 2022
Merged
@dominikbach dominikbach reopened this May 3, 2022
@teddychao teddychao added the Conceptional The pull request includes conceptional updates label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teddychao teddychao

Labels
Conceptional The pull request includes conceptional updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue 366 - pspm_dcm bachlab/PsPM
2 participants
@teddychao @dominikbach