Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: babashka/nbb-prismatic-schema s/set-fn-validation! isn't working as expected #215

Closed
omariosouto opened this issue Jun 12, 2022 · 1 comment

Comments

@omariosouto
Copy link
Contributor

omariosouto commented Jun 12, 2022

version

platform

  • Node: v16.13.0
  • NPM: v8.1.0
  • Yarn: v1.22.17
  • MacBook Pro (13-inch, M1, 2020) | Apple M1 | macOS MOnterey Version 12.4

problem

  • s/set-fn-validation! isn't working as expected

image

repro

Just download these files in this commit: https://github.com/devsoutinho/app-labs/blob/12174ad4518ec8861b72389224aa58f271b313cb/_servers/webproxy/webproxy/app/diplomat/http_server.cljs#L9

expected behavior

  • When run (s/set-fn-validation! false) all validations must be disabled
  • Right now this isn't happening
@borkdude
Copy link
Collaborator

We'll address this as part of schema compatibility when loading schema as a library from source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants