Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: keep start_codebuild.sh up-to-date #5023

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

lrstewart
Copy link
Contributor

@lrstewart lrstewart commented Jan 10, 2025

Release Summary:

Description of changes:

Add an action to make sure start_codebuild.sh from b4a4e09 stays up-to-date with changes to our Codebuild jobs. This might be unnecessary overkill / too much complication for the small benefit / a waste of a github action-- interested in opinions.

Testing:

The test fails if I remove a job from the list in start_codebuild.sh. See https://github.com/aws/s2n-tls/actions/runs/12705769604/job/35417420123?pr=5024

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lrstewart lrstewart marked this pull request as ready for review January 10, 2025 08:21
@lrstewart lrstewart requested a review from dougch as a code owner January 10, 2025 08:21
@lrstewart lrstewart requested a review from jmayclin January 10, 2025 08:21
Copy link
Contributor

@dougch dougch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite my initial trepidation, I get why this is useful...

@lrstewart lrstewart added this pull request to the merge queue Jan 10, 2025
Merged via the queue into aws:main with commit a439c1a Jan 10, 2025
41 checks passed
@lrstewart lrstewart deleted the moreci branch January 10, 2025 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants