Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amazonq): Implement aws/syncModuleDependencies call #5414

Draft
wants to merge 4 commits into
base: feature/q-lsp
Choose a base branch
from

Conversation

samgst-amazon
Copy link
Contributor

@samgst-amazon samgst-amazon commented Feb 26, 2025

Implement the bare structure of the syncModuleDependencies service to make the call from the client to the server

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

added interface for the service handler as well as the data class for the params.

aws/syncModuleDependencies added to AmazonQLanguageServer interface to handle sending the JSONRequests

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Feb 26, 2025

Qodana Community for JVM

6 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 5
Redundant visibility modifier 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

import software.aws.toolkits.jetbrains.services.amazonq.lsp.AmazonQLspService
import software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.dependencies.SyncModuleDependenciesParams

class DefaultModuleDependenciesService(private val project: Project) : ModuleDependenciesService {

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "DefaultModuleDependenciesService" is never used

package software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.dependencies

public class SyncModuleDependenciesParams(

Check warning

Code scanning / QDJVMC

Redundant visibility modifier Warning

Redundant visibility modifier
package software.aws.toolkits.jetbrains.services.amazonq.lsp.model.aws.dependencies

public class SyncModuleDependenciesParams(
val moduleName: String,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "moduleName" is never used
val moduleName: String,
val programmingLanguage: String,
val files: List<String>,
val dirs: List<String>,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "dirs" is never used
val programmingLanguage: String,
val files: List<String>,
val dirs: List<String>,
val includePatterns: List<String>,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "includePatterns" is never used
val files: List<String>,
val dirs: List<String>,
val includePatterns: List<String>,
val excludePatterns: List<String>,

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Property "excludePatterns" is never used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant