Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQSCustomizations #2108

Merged
merged 1 commit into from
May 3, 2023
Merged

Add SQSCustomizations #2108

merged 1 commit into from
May 3, 2023

Conversation

syall
Copy link
Contributor

@syall syall commented Apr 26, 2023

For changes to files under the /codegen/aws-models folder, and manual edits to autogenerated code (e.g. /service/s3/api.go) please create an Issue instead of a PR for those type of changes.

N/A.


If the PR addresses an existing bug or feature, please reference it here.

N/A.


Description

Adds a customization to add default traits to the following members and corresponding top-level input synthetic members, to ensure the default trait is always present:

  • com.amazonaws.sqs#SendMessageRequest$DelaySeconds
  • com.amazonaws.sqs#ChangeMessageVisibilityBatchRequestEntry$VisibilityTimeout
  • com.amazonaws.sqs#SendMessageBatchRequestEntry$DelaySeconds
  • com.amazonaws.sqs#ChangeMessageVisibilityRequest$VisibilityTimeout
  • com.amazonaws.sqs#ReceiveMessageRequest$WaitTimeSeconds
  • com.amazonaws.sqs#ReceiveMessageRequest$VisibilityTimeout
  • com.amazonaws.sqs#ReceiveMessageRequest$MaxNumberOfMessages

Testing

  1. CI passes
  2. Test on locally and verified there are NO breaking changes.

To help speed up the process and reduce the time to merge please ensure that Allow edits by maintainers is checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.

@syall syall marked this pull request as ready for review April 26, 2023 20:50
@syall syall requested a review from a team as a code owner April 26, 2023 20:50
@syall syall force-pushed the sqs-customization branch from 982941e to f12bbbc Compare April 26, 2023 20:58
Copy link
Contributor

@eddy-aws eddy-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this change on behalf of the SQS team.

@syall syall force-pushed the sqs-customization branch from f12bbbc to 8223aa4 Compare April 26, 2023 21:34
@syall syall marked this pull request as draft April 26, 2023 22:48
@syall syall force-pushed the sqs-customization branch 2 times, most recently from 9ecabb5 to 9a9e9d1 Compare May 2, 2023 19:13
@syall syall force-pushed the sqs-customization branch from 9a9e9d1 to 47b9679 Compare May 3, 2023 00:44
@syall syall requested a review from kstich May 3, 2023 00:57
@syall syall marked this pull request as ready for review May 3, 2023 01:05
@syall syall merged commit 829131f into aws:main May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants