Skip to content

Commit

Permalink
fix(cloud-assembly-schema/cli): manifest validation fails on Node <18…
Browse files Browse the repository at this point in the history
….17 (#61)

It looks like `jsonschema 1.5.0` contains changes that are not
compatible with Node versions below 18.17. Hold back the version to
1.4.1.

Relates to aws/aws-cdk#33495

---
By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache-2.0 license

---------

Signed-off-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
  • Loading branch information
rix0rrr and github-actions authored Feb 19, 2025
1 parent f3f0b12 commit bc82193
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .projenrc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ const cloudAssemblySchema = configureProject(
name: '@aws-cdk/cloud-assembly-schema',
description: 'Schema for the protocol between CDK framework and CDK CLI',
srcdir: 'lib',
bundledDeps: ['jsonschema', 'semver'],
bundledDeps: ['jsonschema@~1.4.1', 'semver'],
devDeps: ['@types/semver', 'mock-fs', 'typescript-json-schema', 'tsx'],
disableTsconfig: true,

Expand Down
4 changes: 2 additions & 2 deletions package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/cli-lib-alpha/THIRD_PARTY_LICENSES
Original file line number Diff line number Diff line change
Expand Up @@ -25057,7 +25057,7 @@ OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHE

----------------

** jsonschema@1.5.0 - https://www.npmjs.com/package/jsonschema/v/1.5.0 | MIT
** jsonschema@1.4.1 - https://www.npmjs.com/package/jsonschema/v/1.4.1 | MIT
jsonschema is licensed under MIT license.

Copyright (C) 2012-2015 Tom de Grunt <[email protected]>
Expand Down
1 change: 1 addition & 0 deletions packages/@aws-cdk/cloud-assembly-schema/.projen/deps.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/cloud-assembly-schema/.projen/tasks.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/@aws-cdk/cloud-assembly-schema/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/aws-cdk/THIRD_PARTY_LICENSES
Original file line number Diff line number Diff line change
Expand Up @@ -24850,7 +24850,7 @@ OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHE

----------------

** jsonschema@1.5.0 - https://www.npmjs.com/package/jsonschema/v/1.5.0 | MIT
** jsonschema@1.4.1 - https://www.npmjs.com/package/jsonschema/v/1.4.1 | MIT
jsonschema is licensed under MIT license.

Copyright (C) 2012-2015 Tom de Grunt <[email protected]>
Expand Down
2 changes: 2 additions & 0 deletions packages/aws-cdk/release.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
This file is just here to make this commit count as a change of `aws-cdk`
and have it be released.
2 changes: 1 addition & 1 deletion yarn.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit bc82193

Please sign in to comment.