Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormField/Radio Template static class prevents inline display #868

Open
stokkeland opened this issue Dec 15, 2019 · 0 comments
Open

FormField/Radio Template static class prevents inline display #868

stokkeland opened this issue Dec 15, 2019 · 0 comments

Comments

@stokkeland
Copy link
Contributor

In Template File ui/template/semantic-ui/formfield/radio.html line #2 contains

class="{$class} grouped fields"

Where the grouped class makes it impossible to have an inline display of radio's - and as far as I can tell removeClass is not capable of removing from the template itself.

I am planning to suggest a fix and submit a PR, but it may be a while till i can get to it, i have not adopted 2.0 yet.
The fix could be as simple as removing the class from the template, but i assume many are dependent on this functionality already, so it should likely be accompanied by it being added as a default class for this field type, that can then be removed with removeClass, or perhaps even automagically replaced if addClass('inline') is performed, such magic should then allow something like this in model:

$this->addFields[['standard_payment_terms', 'ui'=>['form'=>['Radio','class'=>['inline']]], 'values'=>[0=>'No',1=>'Yes',9=>'Maybe']]]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants