Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean field compatibility issues #396

Closed
DarkSide666 opened this issue Mar 16, 2019 · 3 comments
Closed

Boolean field compatibility issues #396

DarkSide666 opened this issue Mar 16, 2019 · 3 comments
Assignees
@romaninsh @DarkSide666
Labels
BC-break bug

Comments

@DarkSide666
Copy link
Member

addField('foo', ['type'=>'boolean', 'valueTrue'=>'Y', 'valueFalse'=>'N', 'default'='N']) What values such field supposed to have.

  • what values can be set()
  • what values can be get()
  • how it should typecast when saving
  • how it should typecast when loading
  • will if ($foo->get() === 'N') still work ?
@DarkSide666 DarkSide666 self-assigned this Mar 16, 2019
@romaninsh
Copy link
Member

related to #315

@romaninsh
Copy link
Member

@DarkSide666 if you could contribute test-cases for the above wrongdoings, it should be easier for me to fix.

@mvorisek mvorisek changed the title Field_Boolean compatibility issues Boolean field compatibility issues Aug 25, 2021
@mvorisek
Copy link
Member

partly duplicate of #534

@mvorisek mvorisek mentioned this issue Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romaninsh romaninsh

@DarkSide666 DarkSide666

Labels
BC-break bug
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romaninsh @DarkSide666 @mvorisek