Remove arrow fx coroutines dependency from arrow continuations (#273)

* Remove Arrow Fx Coroutines dependency from Arrow Continuations

* Remove redundant test from Arrow Continuations

Author: nomisRev

arrow-libs/core/arrow-continuations/build.gradle

@@ -12,5 +12,4 @@ dependencies {
     testRuntimeOnly "org.junit.vintage:junit-vintage-engine:$JUNIT_VINTAGE_VERSION"
     testCompileOnly "io.kotlintest:kotlintest-runner-junit5:$KOTLIN_TEST_VERSION", excludeArrow
     testImplementation project(":arrow-core-test")
-    testImplementation "io.arrow-kt:arrow-fx-coroutines:$VERSION_NAME"
 }

arrow-libs/core/arrow-continuations/src/test/kotlin/generic/SuspendingComputationTest.kt

@@ -1,15 +1,9 @@
 package generic
 
-import arrow.continuations.generic.ShortCircuit
 import arrow.core.Left
 import arrow.core.Right
 import arrow.core.computations.either
-import arrow.fx.coroutines.ComputationPool
-import arrow.fx.coroutines.ExitCase
-import arrow.fx.coroutines.Promise
-import arrow.fx.coroutines.bracketCase
 import io.kotlintest.fail
-import io.kotlintest.matchers.types.shouldBeInstanceOf
 import io.kotlintest.shouldBe
 import io.kotlintest.shouldThrow
 import io.kotlintest.specs.StringSpec
@@ -125,26 +119,6 @@ class SuspendingComputationTest : StringSpec({
     } shouldBe Left("test")
   }
 
-  "Short-circuiting cancels Arrow Fx Coroutines" {
-    val exit = Promise<ExitCase>()
-
-    either<String, Int> {
-      val i: Int = bracketCase(
-        acquire = { Unit },
-        use = {
-          Left("hello").invoke()
-        },
-        release = { _, exitCase -> exit.complete(exitCase) }
-      )
-
-      5
-    } shouldBe Left("hello")
-
-    exit.get().shouldBeInstanceOf<ExitCase.Failure> {
-      it.failure.shouldBeInstanceOf<ShortCircuit>()
-    }
-  }
-
   "Short-circuiting cancels KotlinX Coroutines" {
     val scope = CoroutineScope(Dispatchers.Default)
     val latch = CompletableDeferred<Unit>()
@@ -192,7 +166,7 @@ suspend fun completeOnCancellation(latch: CompletableDeferred<Unit>, cancelled:
 
 internal suspend fun Throwable.suspend(): Nothing =
   suspendCoroutineUninterceptedOrReturn { cont ->
-    suspend { throw this }.startCoroutine(Continuation(ComputationPool) {
+    suspend { throw this }.startCoroutine(Continuation(Dispatchers.Default) {
       cont.intercepted().resumeWith(it)
     })
 
@@ -201,7 +175,7 @@ internal suspend fun Throwable.suspend(): Nothing =
 
 internal suspend fun <A> A.suspend(): A =
   suspendCoroutineUninterceptedOrReturn { cont ->
-    suspend { this }.startCoroutine(Continuation(ComputationPool) {
+    suspend { this }.startCoroutine(Continuation(Dispatchers.Default) {
       cont.intercepted().resumeWith(it)
     })