Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Invalid class returned from snmp_settings.vrfs #5035

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Fix(eos_designs): Invalid class returned from snmp_settings.vrfs

Related Issue(s)

Fixes #5031

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Added test for failure reported in bug
  • Confirmed that we returned the EosDesigns subclass (which is a 1:1 replica but still a subclass). The assignement did not tricker a type issue but the merge is more strict, so it failed.
  • Removed all $ref subclasses and instead point directly to the EosCliConfigGen class in the EosDesigns model

How to test

  • Reproduced the issue
  • Dissappeared after the fix
  • No other tests failing

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners February 13, 2025 06:23
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5035
# Activate the virtual environment
source test-avd-pr-5035/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/invalid-class-returned-from-snmp_settings.vrfs#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/invalid-class-returned-from-snmp_settings.vrfs --force
# Optional: Install AVD examples
cd test-avd-pr-5035
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Feb 13, 2025
@ClausHolbechArista ClausHolbechArista added this to the v5.2.2 milestone Feb 13, 2025
@github-actions github-actions bot added the state: conflict PR with conflict label Feb 13, 2025
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the fix/eos_designs/invalid-class-returned-from-snmp_settings.vrfs branch from a311f00 to 2297eca Compare February 13, 2025 14:49
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 13, 2025
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to merge type .EosCliConfigGen.SnmpServer.Vrfs
2 participants