test: fix intermittent cron failures due to parallelism limit #14218
+9
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, the cron E2E suite fails and you'll see the following in the output (example: https://github.com/argoproj/argo-workflows/actions/runs/13480065787/job/37664515754?pr=13747): > ◷ test-cron-wf-fail-1-1740291060 Workflow 0s Workflow processing has been postponed because too many workflows are already running i think this is happening because the `E2ESuite.DeleteResources()` method that's supposed to clean up `CronWorkflow`s from previous tests isn't being run for subtests, and nearly all the tests in `test/e2e/cron_test.go` are subtests. This adds a `TearDownSubTest` method to do so. Docs: https://pkg.go.dev/github.com/stretchr/testify/suite#TearDownSubTest I also deleted the redundant `BeforeTest()` and `TearDownSuite()` methods. Signed-off-by: Mason Malone <[email protected]>
blkperl
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Occasionally, the cron E2E suite fails and you'll see the following in the output (example):
I think this is happening because the
E2ESuite.DeleteResources()method that's supposed to clean upCronWorkflows from previous tests isn't being run for subtests, and nearly all the tests intest/e2e/cron_test.goare subtests.Modifications
This adds a
TearDownSubTestmethod to cleanup all resources after every subtest. Docs:https://pkg.go.dev/github.com/stretchr/testify/suite#TearDownSubTest
I also deleted the redundant
BeforeTest()andTearDownSuite()methods.Verification
Ran
make test-cronlocally