Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus #21937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

Description

github.com/grpc-ecosystem/go-grpc-prometheus is archived since April 18, 2023 and is replaced by github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus.

@mmorel-35 mmorel-35 requested a review from a team as a code owner February 21, 2025 21:20
Copy link

bunnyshell bot commented Feb 21, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Feb 21, 2025

@crenshaw-dev ,

I followed examples/server . I'm probably going to need some help to make integration tests pass

@mmorel-35 mmorel-35 marked this pull request as draft February 21, 2025 21:41
@mmorel-35 mmorel-35 force-pushed the github.com/grpc-ecosystem/go-grpc-prometheus branch from 05563b0 to ee12c3c Compare February 22, 2025 06:56
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Feb 22, 2025

Hi @bwplotka,
As you've contributed to https://github.com/grpc-ecosystem/go-grpc-middleware/tree/providers/prometheus/v1.0.0-rc.0/examples, would you mind having a look on what has been done here ?

Copy link

codecov bot commented Feb 22, 2025

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (master@c09e6fa). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmpserver/server.go 0.00% 7 Missing ⚠️
reposerver/server.go 85.71% 1 Missing ⚠️
server/server.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #21937   +/-   ##
=========================================
  Coverage          ?   53.54%           
=========================================
  Files             ?      342           
  Lines             ?    57090           
  Branches          ?        0           
=========================================
  Hits              ?    30568           
  Misses            ?    23928           
  Partials          ?     2594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmorel-35 mmorel-35 marked this pull request as ready for review February 22, 2025 07:38
@mmorel-35 mmorel-35 force-pushed the github.com/grpc-ecosystem/go-grpc-prometheus branch from ee12c3c to 48abaf2 Compare February 22, 2025 17:53
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmorel-35 mmorel-35 force-pushed the github.com/grpc-ecosystem/go-grpc-prometheus branch 2 times, most recently from 5ca6145 to e73ff8e Compare February 26, 2025 19:01
@mmorel-35 mmorel-35 force-pushed the github.com/grpc-ecosystem/go-grpc-prometheus branch from e73ff8e to eba3161 Compare February 26, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for final review
Development

Successfully merging this pull request may close these issues.

3 participants