Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(health): resource customization for RabbitMQCluster #15286

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

aaguilartablada
Copy link
Contributor

This pull request creates a new 'Resource Customization' for RabbitMQCluster CRD managed by RabbitMQ Cluster Operator (https://www.rabbitmq.com/kubernetes/operator/operator-overview.html).

@aaguilartablada aaguilartablada changed the title Resource customization: RabbitMQCluster featyre: resource customization for RabbitMQCluster Aug 30, 2023
@aaguilartablada aaguilartablada changed the title featyre: resource customization for RabbitMQCluster feature: resource customization for RabbitMQCluster Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.78%. Comparing base (ae028c2) to head (a245fbe).
Report is 429 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15286      +/-   ##
==========================================
- Coverage   55.81%   55.78%   -0.04%     
==========================================
  Files         320      320              
  Lines       44396    44396              
==========================================
- Hits        24781    24767      -14     
- Misses      17050    17069      +19     
+ Partials     2565     2560       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson blakepettersson changed the title feature: resource customization for RabbitMQCluster feat: resource customization for RabbitMQCluster Sep 21, 2023
@aaguilartablada
Copy link
Contributor Author

aaguilartablada commented Oct 11, 2023

Can anyone review this PR, please?
(@blakepettersson ?)

@blakepettersson
Copy link
Member

@aaguilartablada I haven't used RabbitMQCluster CRD so I'm not sure how useful I'd be in this context. Have you taken a look at the feedback given by @Zerpet?

@crenshaw-dev crenshaw-dev changed the title feat: resource customization for RabbitMQCluster feat(health): resource customization for RabbitMQCluster Oct 11, 2023
@aaguilartablada
Copy link
Contributor Author

@aaguilartablada I haven't used RabbitMQCluster CRD so I'm not sure how useful I'd be in this context. Have you taken a look at the feedback given by @Zerpet?

Yes! And I think that what he requested is already covered

Copy link

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is covered here:

if condition.type == "ReconcileSuccess" and condition.status == "False" then
hs.status = "Degraded"
hs.message = condition.message
return hs
end

From the RabbitMQ PoV, this PR covers and inspects all the relevant status conditions. I know very little about ArgoCD, and it's my first time around here, so I will defer the approval to one of the maintainers 🙂

@cosimomeli
Copy link

Any news on this?

@aaguilartablada aaguilartablada requested a review from a team as a code owner March 19, 2024 11:30
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) September 18, 2024 18:02
@crenshaw-dev crenshaw-dev merged commit 7d28c89 into argoproj:master Sep 18, 2024
25 of 27 checks passed
adriananeci pushed a commit to adriananeci/argo-cd that referenced this pull request Dec 4, 2024
…5286)

Signed-off-by: Álvaro Aguilar <[email protected]>
Co-authored-by: Blake Pettersson <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants