-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(health): resource customization for RabbitMQCluster #15286
Conversation
Signed-off-by: Álvaro Aguilar <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #15286 +/- ##
==========================================
- Coverage 55.81% 55.78% -0.04%
==========================================
Files 320 320
Lines 44396 44396
==========================================
- Hits 24781 24767 -14
- Misses 17050 17069 +19
+ Partials 2565 2560 -5 ☔ View full report in Codecov by Sentry. |
Can anyone review this PR, please? |
@aaguilartablada I haven't used RabbitMQCluster CRD so I'm not sure how useful I'd be in this context. Have you taken a look at the feedback given by @Zerpet? |
Yes! And I think that what he requested is already covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed it is covered here:
if condition.type == "ReconcileSuccess" and condition.status == "False" then | |
hs.status = "Degraded" | |
hs.message = condition.message | |
return hs | |
end |
From the RabbitMQ PoV, this PR covers and inspects all the relevant status conditions. I know very little about ArgoCD, and it's my first time around here, so I will defer the approval to one of the maintainers 🙂
Any news on this? |
…5286) Signed-off-by: Álvaro Aguilar <[email protected]> Co-authored-by: Blake Pettersson <[email protected]> Signed-off-by: Adrian Aneci <[email protected]>
This pull request creates a new 'Resource Customization' for RabbitMQCluster CRD managed by RabbitMQ Cluster Operator (https://www.rabbitmq.com/kubernetes/operator/operator-overview.html).