Skip to content
This repository was archived by the owner on Dec 13, 2023. It is now read-only.

AQL: Multi-line comments must be terminated from 3.6.0 on #185

Closed
Simran-B opened this issue Oct 11, 2019 · 3 comments
Closed

AQL: Multi-line comments must be terminated from 3.6.0 on #185

Simran-B opened this issue Oct 11, 2019 · 3 comments
Assignees
@Simran-B
Labels
1 Feature
Milestone
3.6

Comments

@Simran-B
Copy link
Collaborator

The following is not allowed in current devel anymore:

RETURN 1
/*
RETURN 2

There must not be an unterminated multi-line comment:

RETURN 1
/*
RETURN 2
*/

Counts don't have to match, as anything between /* and */ is considered as comment body, including additional /*.

Prism.js needs to be updated as well!
@Simran-B Simran-B added this to the 3.6 milestone Oct 11, 2019
@Simran-B Simran-B self-assigned this Oct 11, 2019
@jsteemann
Copy link
Contributor

Note that this is not only 3.6 and onwards.
The "fix" has also been backported to 3.4 and 3.5 IIRC.

@Simran-B Simran-B mentioned this issue Oct 14, 2019
Merged
@Simran-B
Copy link
Collaborator Author

Prism.js PR opened: PrismJS/prism#2089

It is no longer allowed to have unterminated multi-line comments in AQL (as a side-effect of a bug-fix to prevent unterminated strings) from these versions on:

@Simran-B
Copy link
Collaborator Author

Nothing says that it was supported to have unterminated multi-line comments, so nothing to change in the docs IMO:
https://www.arangodb.com/docs/stable/aql/fundamentals-syntax.html#comments

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Simran-B Simran-B

Labels
1 Feature
Projects
None yet
Milestone
3.6
Development

No branches or pull requests
2 participants
@jsteemann @Simran-B