-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Actions for checks #885
base: main
Are you sure you want to change the base?
Conversation
Hi @StefMa, thanks for the PR! We're considering switching to GitHub Actions, but we're not quite ready yet to accept a commit for this. However, you can always maintain this commit on your own fork for now as a way to build and test Pkl yourself. However, this is quite useful for us (I've never used GHA before), so, let's keep this PR around so we can go from here when we're ready! Also, I'm open to using pkl-gha :) |
@bioball Actions are currently disabled on the repo, but would it be useful to merge anyway so that other folks who are forking can run the tests? I wouldn't want this to turn into a maintenance burden for the team to have untested code in the repo, but it could also be a nice quality of life improvement for contributors. |
In case it helps forks in the meantime, here are some workflows that I've used to test PRs before submitting them to Pkl upstream. The build summary shows how jobs are arranged, with Gradle and Native Image build reports, and so on. The workflows use StepSecurity's actions to harden execution (disables I'd be glad to offer these upstream if the project is interested, or on this PR, but I suspect the Pkl project authors will want to render these configs with Pkl, as is done for Circle |
Sure, take your time. This is going to nowhere 🙃
Nice to hear! If you have any feedback to it, let me know. I tend to agree with @madrob. @sgammon nice, thanks for sharing that! |
Hello everyone ✌️
this PR might fix #152 and therefore also contributes to #225.
Two reasons why this would be a step forward:
I just converted the
checks
from the circleci config for now becauseLe me know if this is "fine" or if I also convert all the other jobs.
On the other side we can also do this as follow-ups in other PRs.
Let me know what you prefer.
Because using a matrix is super easy to setup on actions, I also decided to run jdk 21 on windows 🤷
This isn't in the circleci config but doesn't hurt i guess?!
If you want to see how this looks like in action, checkout this run on my fork:
TODO before merge: