Skip to content

Commit

Permalink
- This change is in the context of the change made in PR
Browse files Browse the repository at this point in the history
#11815 in "main".
In case of spill by reference, log servers should use the logic that
is based over "TagData::popped" to decide how long to keep the disk
queue positions of versions in memory (instead of using the logic that
is based over "LogData::persistentDataVersion", which is applicable to
spill by value case).
  • Loading branch information
sbodagala committed Dec 10, 2024
1 parent dfb2d97 commit 9249ca1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fdbserver/TLogServer.actor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1225,7 +1225,7 @@ ACTOR Future<Void> updatePersistentData(TLogData* self, Reference<LogData> logDa
self->persistentQueue->forgetBefore(
(!SERVER_KNOBS->ENABLE_VERSION_VECTOR_TLOG_UNICAST
? newPersistentDataVersion
: std::min(newPersistentDataVersion, logData->knownCommittedVersion)),
: std::min(minVersion, logData->knownCommittedVersion)),
logData); // SOMEDAY: this can cause a slow task (~0.5ms), presumably from erasing too many versions.
// Should we limit the number of versions cleared at a time?
}
Expand Down

0 comments on commit 9249ca1

Please sign in to comment.