Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for self-signed certs? #199

Closed
Panoplos opened this issue Aug 1, 2017 · 11 comments
Closed

Support for self-signed certs? #199

Panoplos opened this issue Aug 1, 2017 · 11 comments
Labels
🔨 cli related to the CLI itself 🎉 feature New addition or enhancement to existing solutions

Comments

@Panoplos
Copy link

Panoplos commented Aug 1, 2017

When developing locally, it is important to support self-signed certs. I believe adding this is quite simple and can be disabled by default for security reason.

@martijnwalraven
Copy link
Contributor

Do you mean supporting self-signed certs for downloading the schema?

@Panoplos
Copy link
Author

Panoplos commented Aug 1, 2017

Yes

@Panoplos
Copy link
Author

Panoplos commented Aug 1, 2017

Note that I implemented this in gql2flow (before knowing about this tool).
joarwilk/gql2flow#30

@martijnwalraven
Copy link
Contributor

@Panoplos: Seeing as you've already implemented this, a PR would be very welcome!

@rricard rricard added 🔨 cli related to the CLI itself easy labels Aug 2, 2017
@xrd
Copy link

xrd commented May 3, 2018

I think this is done, via the -K true switch.

insecure: {
        alias: 'K',
        describe: 'Allows "insecure" SSL connection to the server',
        type: 'boolean'
      },

@schleumer
Copy link

schleumer commented May 12, 2018

@xrd even when using --insecure, --insecure=true, -K, -K true, or any other variation i still get error: Error while fetching introspection query result: Protocol "http:" not supported. Expected "https:", i think that flag means that it can be a insecure connection somehow but not a self-signed cert or HTTP, a look at source: https://github.com/apollographql/apollo-codegen/blob/master/src/downloadSchema.ts#L20 and removing that line and its reference helped me to download a schema via HTTP

Edited:

After rereading the code noticed that --insecure actually forces connections through HTTPS 😅

@maarekj
Copy link

maarekj commented Jul 5, 2018

Has --insecure option disappeared ?

@shadaj shadaj added 🎉 feature New addition or enhancement to existing solutions and removed enhancement labels Jul 5, 2018
@SimonCropp
Copy link

i have the same question as @maarekj

@robertomg
Copy link
Contributor

We need to support this feature. Our team is also using a self-signed certificate for development.

@maarekj
Copy link

maarekj commented Nov 20, 2018

This option has disappeared again

@hally9k
Copy link

hally9k commented Feb 12, 2019

I'm also having trouble getting this working 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 cli related to the CLI itself 🎉 feature New addition or enhancement to existing solutions
Projects
None yet
Development

No branches or pull requests

10 participants