[SPARK-45658][SQL] Fix canonicalization of DynamicPruningSubquery to canonicalize build keys relative to build query output #49154
+21
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alize build keys relative to build query output
added 2 commits
December 11, 2024 19:17
…alize build keys relative to build query output. fix compilation error after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fixing the canonicalization of build keys in the DynamicPruningSubquery so that build keys are canonicalized relative to build query output.
Why are the changes needed?
I discovered this issue while working on my other PR for pushing broadcast data of BroadcastHashJoin as a pruning filter. The bug appeared as two DynamicPruningSubquery though equivalent, on canonicalization, were not matching. It turned out that the build keys expression were getting canonicalized relative to itself, instead of build query 's output.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Added bug test.
Was this patch authored or co-authored using generative AI tooling?
No