skywalking support ibm websphere(was ) j9vm #2652
Comments
|
I think we can't support them in Apache. The Oracle and IBM Web Containers are commercial products. We can't use their jar libs. Volunteer may choose to open them at their personal repository as extension. |
|
Yes, we are eager for this feature too. |
|
Are we talking about j9vm or websphere here? |
I also face the same problem, WebSphere 6.x/7.x/8.x， drive me crazy！ |
|
i am not sure if the grpc & protobuf caused the problem or not, but i met so exception on was7.0 & j9vm1.7.0_20150407 just like that: |
|
This is not an issue, this is protected by agent APIs. Only output a log, I remember it is a warning level, right? |
|
I have tested WebSphere 7.0.0.11 with ibm jdk 1.8_20160719 and 1.7.0_20150407, skywalking-agent has the same logs. WARN 2019-05-09 17:01:35:905 SkywalkingAgent-1-GRPCChannelManager-0 ProtectiveShieldMatcher : Byte-buddy occurs exception when match type. |
|
My question is, what happens after this WARN log. I expect everything is still working. |
|
After this WARN log, WebSphere failed to start. |
|
From the logs, I think should add more ignore in byte-buddy match. |
wu-sheng
added
bug
|
@pmq5205209 I have read the logs, and add more ignore in branch |
|
I can do this right now. |
|
I copied your SkyWalkingAgent.java , and replace mine. I built the project and tested. The logs are almost the same as yesterday. |
|
Moving to discussion to byte-buddy, raphw/byte-buddy#652 |
|
@pmq5205209 I am trying to follow Rafael's suggestion to provide a class file locator. Could you show me, how could I set the location? Such as, where are your jdk jars? Or other lib jars? |
We use WebSphere's default jdk whose location is "C:\Program Files (x86)\IBM\WebSphere\AppServer3\java". When I replace the jdk version, I just replace this file. |
|
Are all jars of JRE in that folder? |
|
|
|
You need to find jars including those classes in your error log. I think there includes JRE jars and WebSphere jars. |
|
I cannot find any jars including those classes in the error log. But I find classes in src.zip of WebShpere's default java path. Such as "java.security.BasicPermission". |
|
This is src, we need the class jar or folders. |
I found the jar which is name rt.jar whose path is "C:\Program Files (x86)\IBM\WebSphere\AppServer3\java\jre\lib\rt.jar". |
|
Could you give #2708 a try? |
|
Hi, WuSheng, I had Solved the problem of "java.security.PrivilegedAction". I set the agent's owner to the owner of WebSphere. And add "grant codeBase "file:${agent_dir}/-" { permission java.security.AllPermission; };" in the file of "server.policy". Now skywalking agent can run in WebSphere 6.1 ,7.0, 8.0 with openjdk 1.6.0 , and Apps run normally. |
|
This is high-value solution, you should send a pull request to FAQ. The FAQ should be linked and placed here, https://github.com/apache/skywalking/blob/master/docs/en/FAQ/README.md#runtime |
|
For your plugin, could you see any log output by ClassLoader classLoader, JavaModule module) {
List<AbstractClassEnhancePluginDefine> pluginDefines = pluginFinder.find(typeDescription);
if (pluginDefines.size() > 0) {
DynamicType.Builder<?> newBuilder = builder;
EnhanceContext context = new EnhanceContext();
for (AbstractClassEnhancePluginDefine define : pluginDefines) {
DynamicType.Builder<?> possibleNewBuilder = define.define(typeDescription, newBuilder, classLoader, context);
if (possibleNewBuilder != null) {
newBuilder = possibleNewBuilder;
}
}
if (context.isEnhanced()) {
logger.debug("Finish the prepare stage for {}.", typeDescription.getName());
}
return newBuilder;
}
logger.debug("Matched class {}, but ignore by finding mechanism.", typeDescription.getTypeName());
return builder; |
Which Oracle plugin are you talking about? |
wu-sheng
added
question
|
I download oracle plugin and add it to my local skywalking. |
|
OK, If oracle plugin works then you means the java agent core should run perfectly. Then 2 things
|
|
OK. I will do more try to develop WebSphere plugin, because we have an important customer whose uses many WebSphere. |
I am just saying, when SpringMVC active, you even can't see WebSphere in tracing. |
|
I know that. But We face a problem that these apps are too old. |
|
Got it, then follow my suggestions, let's see what happened. |
|
OK. I will do it in these days. |
|
As FAQ doc provided, I think installation in Websphere should be fixed. |
Please answer these questions before submitting your issue.
Question
We strongly expect skywalking to support IBM & Oracle Web Containers, because so many product environments run on websphere and weblogic , we believe this feature can greatly improve the skywalking application scenario. thanks.
Bug
Which version of SkyWalking, OS and JRE?
skywalking 6.1
websphere 6.1+ J9VM 1.6.0+
Which company or project?
What happen?
If possible, provide a way for reproducing the error. e.g. demo application, component version.
Requirement or improvement
The text was updated successfully, but these errors were encountered: