Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/rocketmq
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b00681b90506f8b241e7bdd8fa1628c6292df608
Choose a base ref
..
head repository: apache/rocketmq
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 335312bb3bd71f70626a666cbdd013c7b4f2daf0
Choose a head ref
Showing with 1 addition and 1 deletion.
  1. +1 −1 client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
2 changes: 1 addition & 1 deletion client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
View file
Original file line number Diff line number Diff line change
@@ -653,7 +653,7 @@ private PopResult processPopResult(final PopResult popResult, final Subscription
Iterator<MessageExt> iterator = msgListFilterAgain.iterator();
while (iterator.hasNext()) {
MessageExt msg = iterator.next();
if(msg.getReconsumeTimes() > defaultMQPushConsumer.getMaxReconsumeTimes()) {
if (msg.getReconsumeTimes() > defaultMQPushConsumer.getMaxReconsumeTimes()) {
iterator.remove();
log.info("Reconsume times has reached {}, so ack msg={}", msg.getReconsumeTimes(), msg);
}