[ISSUE #2588] Duplicate invoke of countdown in processReplyMessage

kelvin17 · yanqing.qyq · web-flow · commit 79ed2b6f894c · 2021-01-13T14:14:07.000+08:00
Co-authored-by: yanqing.qyq &lt;yanqing.qyq@antfin.com&gt;
diff --git a/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java b/client/src/main/java/org/apache/rocketmq/client/impl/ClientRemotingProcessor.java
@@ -282,8 +282,6 @@ private void processReplyMessage(MessageExt replyMsg) {
 
             if (requestResponseFuture.getRequestCallback() != null) {
                 requestResponseFuture.getRequestCallback().onSuccess(replyMsg);
-            } else {
-                requestResponseFuture.putResponseMessage(replyMsg);
             }
         } else {
             String bornHost = replyMsg.getBornHostString();

Original file line number	Diff line number	Diff line change
`@@ -282,8 +282,6 @@ private void processReplyMessage(MessageExt replyMsg) {`
`282`	`282`
`283`	`283`	`if (requestResponseFuture.getRequestCallback() != null) {`
`284`	`284`	`requestResponseFuture.getRequestCallback().onSuccess(replyMsg);`
`285`		`- } else {`
`286`		`- requestResponseFuture.putResponseMessage(replyMsg);`
`287`	`285`	`}`
`288`	`286`	`} else {`
`289`	`287`	`String bornHost = replyMsg.getBornHostString();`