Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netbeans javadoc links to ancient java se javadoc #8254

Open
homberghp opened this issue Feb 17, 2025 · 3 comments · May be fixed by #8263
Open

netbeans javadoc links to ancient java se javadoc #8254

homberghp opened this issue Feb 17, 2025 · 3 comments · May be fixed by #8263
Labels
build CI continuous integration changes JavaDoc [ci] enable java/javadoc tests and build-javadoc target kind:bug Bug report or fix nb-javac Run nb-javac integration tests
Milestone

Comments

@homberghp
Copy link
Contributor

Apache NetBeans version

Apache NetBeans 25 release candidate

What happened

It is not a netbeans bug perse, but rather annoying.
When you lookup javadoc for say the netbeans-25 apis, following the links to some JDK apis, such as say ClassTree, you land in a Java SE 6 version of the com.sun javadoc.

Language / Project Type / NetBeans Component

javadoc

How to reproduce

look up WorkingCopy in java/java.source.base and click on e.g. Tree.
This will land you in https://docs.oracle.com/javase/6/docs/jdk/api/javac/tree/com/sun/source/tree/Tree.html?is-external=true
where https://docs.oracle.com/en/java/javase/17/docs/api/jdk.compiler/com/sun/source/tree/Tree.html would be more appropriate, since 17 is the min version for building netbeans >= 24.

Did this work correctly in an earlier version?

No / Don't know

Operating System

any, the problem lies on the server or deployment side

JDK

jdk 17

Apache NetBeans packaging

Other

Anything else

it is just an annoyance, and probably only a setting in one of the ant scripts or properties.
Other modules link to more up to date javadoc sites (such as java 8).

Are you willing to submit a pull request?

Yes

@homberghp homberghp added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Feb 17, 2025
@mbien mbien added JavaDoc [ci] enable java/javadoc tests and build-javadoc target CI continuous integration changes build and removed needs:triage Requires attention from one of the committers labels Feb 18, 2025
@mbien mbien added this to the NB26 milestone Feb 18, 2025
@mbien
Copy link
Member

mbien commented Feb 18, 2025

the doc is currently linked with the JDK 8 API

<property name="javadoc.docs.jdk" value="https://docs.oracle.com/javase/8/docs/api"/>
which we should probably bump to 17.

There compiler classes are a special case since NB ships with the latest build (currently based on JDK 24 javac). So it doesn't surprise me that they have some linking issues since the situation is a bit unusual there.

@mbien mbien added the nb-javac Run nb-javac integration tests label Feb 18, 2025
@ebarboni
Copy link
Contributor

We need both to match with jdk we use for javadoc build but with jdk 11 we have module before classtree

https://github.com/apache/netbeans/blob/master/nbbuild/javadoctools/links.xml contains the ref to faulty doc

@ebarboni
Copy link
Contributor

ebarboni commented Feb 21, 2025

Hope I find the way to workaround the issue. I will try to have a script to changes @JDK@/... to @JDK@@JAVAMODULE....@ in a manner I can reapply on the previous release back to a certain point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI continuous integration changes JavaDoc [ci] enable java/javadoc tests and build-javadoc target kind:bug Bug report or fix nb-javac Run nb-javac integration tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants