Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable changing the CIDR on shared networks when no IP ranges are defined #10459

Open
borisstoyanov opened this issue Feb 25, 2025 · 1 comment

Comments

@borisstoyanov
Copy link
Contributor

The required feature described as a wish

As an admin I'd love to be able to change the CIDR of a shared network when there's no IP ranges defined. I appeaciate if there are VMs running they can end up on different CIDRs while on the same network, we want to avoid that. So my suggestion is to check if there are IP ranges defined, if no, this basically means there's no VMs on the network, at this stage this should allow the change of the CIDR, thoughts?

@adietrich-ussignal
Copy link

While I am very close to the original request, I think it only partially captures the desired behavior. I feel that having the ability to change the CIDR when one already exists is still a valid behavior that should be accounted for in this, given appropriate guardrails. I would think a CIDR change should also be permitted if no instances exist on said network. Accounting for the virtual router, either have the VR stop when this is performed, or require the operator to stop the VR before changing the CIDR on an existing shared network with a CIDR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants