Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Toggle whiteboard" control icon & label do not match #18027

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snowtimeglass
Copy link
Contributor

Purpose / Description

"Toggle whiteboard" control icon does not match the label and the actual action.



Fixes

Approach

  • For the "Toggle whiteboard" item in Controls settings page, replace the current "Hide whiteboard" icon with "Enable whiteboard" icon
  • Add a new control item for "Show/Hide whiteboard"

How Has This Been Tested?

Checked on physical device (Android 11)


"Toggle whiteboard" behavior

Record_2025-02-26-10-49-34_7b5228b5a93c00ecba98ecb0735c59e2.mp4

"Show/Hide whiteboard" behavior

Record_2025-02-26-12-01-23_7b5228b5a93c00ecba98ecb0735c59e2.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

- For the "Toggle whiteboard" label in Controls settings page, replace the current "Show/Hide whiteboard" icon with "Enable whiteboard" icon
- Add a new control item for "Show/Hide whiteboard"
Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Toggle whiteboard" control icon & label do not match
1 participant