Comments in xml flexforms are indented wrong

[wtfred]

When you have comments in xml flexforms, your indentation is getting broken

If you have this

<?xml version="1.0"?>
<T3DataStructure>
    <sheets>
        <sDEF>
            <ROOT>
                <sheetTitle>Sheet Title</sheetTitle>
                <type>array</type>
                <el>
                    <!-- test comment -->
                    <selectSingleColumn>
                        <config>
                            <type>select</type>
                            <renderType>selectSingle</renderType>
                            <items type="array">
                                <numIndex index="0" type="array">
                                    <label/>
                                    <value/>
                                </numIndex>
                                <numIndex index="1" type="array">
                                    <label>Label 1</label>
                                    <value>1</value>
                                </numIndex>
                                <numIndex index="2" type="array">
                                    <label>Label 2</label>
                                    <value>2</value>
                                </numIndex>
                                <numIndex index="3" type="array">
                                    <label>Label 3</label>
                                    <value>3</value>
                                </numIndex>
                            </items>
                        </config>
                    </selectSingleColumn>
                </el>
            </ROOT>
        </sDEF>
    </sheets>
</T3DataStructure>

Fractor will indent it like this

<?xml version="1.0"?>
<T3DataStructure>
    <sheets>
        <sDEF>
            <ROOT>
                <sheetTitle>Sheet Title</sheetTitle>
                <type>array</type>
                <el>
                    <!-- test comment -->
                        <selectSingleColumn>
                            <config>
                                <type>select</type>
                                <renderType>selectSingle</renderType>
                                <items type="array">
                                    <numIndex index="0" type="array">
                                        <label/>
                                        <value/>
                                    </numIndex>
                                    <numIndex index="1" type="array">
                                        <label>Label 1</label>
                                        <value>1</value>
                                    </numIndex>
                                    <numIndex index="2" type="array">
                                        <label>Label 2</label>
                                        <value>2</value>
                                    </numIndex>
                                    <numIndex index="3" type="array">
                                        <label>Label 3</label>
                                        <value>3</value>
                                    </numIndex>
                                </items>
                            </config>
                        </selectSingleColumn>
                    </el>
                </ROOT>
            </sDEF>
        </sheets>
    </T3DataStructure>

The more comments you have, the more it get shifted to the right

<?xml version="1.0"?>
<T3DataStructure>
    <sheets>
        <sDEF>
            <ROOT>
                <sheetTitle>Sheet Title</sheetTitle>
                <type>array</type>
                <el>
                    <!-- test comment -->
                        <selectSingleColumn>
                            <config>
                                <type>select</type>
                                <renderType>selectSingle</renderType>
                                <items type="array">
                                    <numIndex index="0" type="array">
                                        <label/>
                                        <value/>
                                    </numIndex>
                                    <numIndex index="1" type="array">
                                        <label>Label 1</label>
                                        <value>1</value>
                                    </numIndex>
                                </items>
                            </config>
                        </selectSingleColumn>
                        <!-- test comment 2 -->
                            <selectSingleColumn2>
                                <config>
                                    <type>select</type>
                                    <renderType>selectSingle</renderType>
                                    <items type="array">
                                        <numIndex index="0" type="array">
                                            <label/>
                                            <value/>
                                        </numIndex>
                                        <numIndex index="1" type="array">
                                            <label>Label 1</label>
                                            <value>1</value>
                                        </numIndex>
                                    </items>
                                </config>
                            </selectSingleColumn2>
                            <!-- test comment 3 -->
                                <selectSingleColumn3>
                                    <config>
                                        <type>select</type>
                                        <renderType>selectSingle</renderType>
                                        <items type="array">
                                            <numIndex index="0" type="array">
                                                <label/>
                                                <value/>
                                            </numIndex>
                                            <numIndex index="1" type="array">
                                                <label>Label 1</label>
                                                <value>1</value>
                                            </numIndex>
                                        </items>
                                    </config>
                                </selectSingleColumn3>
                            </el>
                        </ROOT>
                    </sDEF>
                </sheets>
            </T3DataStructure

[simonschaufi]

That is a bug in a third party library that we use. See shanethehat/pretty-xml#11. I hope this bug will be fixed there soon.

[andreaswolf]

I tried fixing it by myself, but did not manage to, since the library only handles opening/closing tags correctly, but not self-closing tags (or comments) AFAICS.