Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlexForm fractors: Add abstraction for column structure #142

Open
andreaswolf opened this issue Jun 9, 2024 · 1 comment
Open

FlexForm fractors: Add abstraction for column structure #142

andreaswolf opened this issue Jun 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@andreaswolf
Copy link
Owner

Since traversing the XML structure for a single column requires XML operations e.g. for finding nodes and checking values, we should make the implicit structural knowledge explicit by creating a wrapper class for the structure. This would serve the same purpose as the current trait \a9f\Typo3Fractor\Helper\FlexFormHelperTrait.

The new class should accept a DOMNode for either the whole column configuration or the <config> sub node (the latter would make it easier to check if the correct column was passed in the constructor).

The class should have methods for retrieving the config type, render type, changing the TCA type, render type, …

Alternatively, we could also decide on not handling all this in XML, but converting the XML to a PHP array in the constructor and back to XML in a separate method (which is how the core handles this as well).

@simonschaufi
Copy link
Collaborator

I would love the xml to PHP transformation as it would make the rules so much easier as you could basically copy the tca migrations from the core then.

@simonschaufi simonschaufi added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants