[TASK] Configuration not needed anymore due to installer

Author: sabbelasichon

composer.json

@@ -84,24 +84,31 @@
     },
     "config": {
         "allow-plugins": {
+            "a9f/fractor-extension-installer": true,
             "ergebnis/composer-normalize": true
         }
     },
     "extra": {
         "class": "a9f\\FractorExtensionInstaller\\InstallerPlugin"
     },
     "scripts": {
+        "auto-scripts": {
+            "fractor:installer": "a9f\\FractorMonorepo\\Composer\\Scripts\\FractorPackageInstaller::generate"
+        },
         "analyze:php": "phpstan analyze",
         "contribute": [
             "@style:composer:normalize:fix",
             "@merge-composer-json"
         ],
-        "propagate": "monorepo-builder propagate",
-        "validate-monorepo": "monorepo-builder validate",
-        "release": "monorepo-builder release patch",
+        "docs": [
+            "fractor-doc-generator generate packages/typo3-fractor/rules --output-file packages/typo3-fractor/docs/typo3-fractor-rules.md",
+            "fractor-doc-generator generate packages/fractor-composer-json/rules --output-file packages/fractor-composer-json/docs/composer-json-fractor-rules.md"
+        ],
         "merge-composer-json": "monorepo-builder merge",
+        "propagate": "monorepo-builder propagate",
         "rectify": "rector",
         "rector": "rector --dry-run",
+        "release": "monorepo-builder release patch",
         "style:composer:normalize": [
             "@composer normalize --dry-run e2e/composer.json",
             "@composer normalize --dry-run packages/extension-installer/composer.json",
@@ -124,12 +131,23 @@
             "@composer normalize --no-check-lock packages/fractor-yaml/composer.json",
             "@composer normalize --no-check-lock packages/typo3-fractor/composer.json"
         ],
-        "docs": [
-            "fractor-doc-generator generate packages/typo3-fractor/rules --output-file packages/typo3-fractor/docs/typo3-fractor-rules.md",
-            "fractor-doc-generator generate packages/fractor-composer-json/rules --output-file packages/fractor-composer-json/docs/composer-json-fractor-rules.md"
+        "local:contribute": [
+            "@rectify",
+            "@analyze:php",
+            "@style:php:fix",
+            "@style:composer:normalize:fix",
+            "@test:php"
         ],
         "style:php:check": "ecs",
         "style:php:fix": "ecs --fix",
-        "test:php": "phpunit"
+        "test:php": "phpunit",
+        "validate-monorepo": "monorepo-builder validate",
+        "post-install-cmd": [
+            "@auto-scripts"
+        ],
+        "post-update-cmd": [
+            "@auto-scripts"
+        ]
     }
+
 }

ecs.php

@@ -33,6 +33,7 @@
         OperatorLinebreakFixer::class,
 
     ])
+    ->withSkip([__DIR__ . '/packages/extension-installer/generated'])
     ->withPreparedSets(psr12: true, symplify: true, common: true, cleanCode: true)
     ->withPaths([__DIR__ . '/e2e', __DIR__ . '/src', __DIR__ . '/packages'])
     ->withRootFiles();

packages/extension-installer/composer.json

@@ -23,11 +23,6 @@
             "a9f\\FractorExtensionInstaller\\Generated\\": "generated/"
         }
     },
-    "config": {
-        "allow-plugins": {
-            "ergebnis/composer-normalize": true
-        }
-    },
     "extra": {
         "branch-alias": {
             "dev-main": "0.2-dev"

packages/extension-installer/src/PackagesFileGenerator.php

@@ -37,14 +37,26 @@ public function generate(): void
             }
 
             $path = $this->installationManager->getInstallPath($package);
+
+            if ($path === null) {
+                continue;
+            }
+
             $installedPackages[$package->getName()] = [
-                'name' => $package->getName(),
                 'path' => $path,
-                'version' => $package->getFullPrettyVersion(),
             ];
         }
+
+        self::write($installedPackages, $this->fileToGenerate);
+    }
+
+    /**
+     * @param array<string, array{'path': string}> $installedPackages
+     */
+    public static function write(array $installedPackages, string $fileToGenerate): void
+    {
         $installedPackagesCode = var_export($installedPackages, true);
 
-        file_put_contents($this->fileToGenerate, sprintf(self::FILE_TEMPLATE, $installedPackagesCode));
+        file_put_contents($fileToGenerate, sprintf(self::FILE_TEMPLATE, $installedPackagesCode));
     }
 }

packages/fractor-fluid/composer.json

@@ -40,8 +40,7 @@
     },
     "config": {
         "allow-plugins": {
-            "a9f/fractor-extension-installer": true,
-            "ergebnis/composer-normalize": true
+            "a9f/fractor-extension-installer": true
         },
         "sort-packages": true
     },

packages/fractor-fluid/tests/FluidFileProcessor/config/fractor.php

@@ -6,5 +6,4 @@
 use a9f\FractorFluid\Tests\Fixtures\DummyFluidFractorRule;
 
 return FractorConfiguration::configure()
-    ->import(__DIR__ . '/../../../config/application.php')
     ->withRules([DummyFluidFractorRule::class]);

packages/fractor-yaml/tests/YamlFileProcessor/config/fractor.php

@@ -6,5 +6,4 @@
 use a9f\FractorYaml\Tests\Fixtures\DummyYamlFractorRule;
 
 return FractorConfiguration::configure()
-    ->import(__DIR__ . '/../../../config/application.php')
     ->withRules([DummyYamlFractorRule::class]);

packages/fractor/composer.json

@@ -38,9 +38,6 @@
         "bin/fractor"
     ],
     "config": {
-        "allow-plugins": {
-            "ergebnis/composer-normalize": true
-        },
         "sort-packages": true
     },
     "extra": {

packages/fractor/src/Testing/PHPUnit/AbstractFractorTestCase.php

@@ -47,6 +47,8 @@ protected function tearDown(): void
             // restore copied file
             FileSystem::rename($this->copiedFile, $this->inputFilePath);
         }
+
+        unset($this->currentContainer);
     }
 
     public function provideConfigFilePath(): ?string

packages/fractor/tests/Configuration/AllowedFileExtensionsResolver/AllowedFileExtensionsResolverTest.php

@@ -15,8 +15,8 @@ public function test(): void
         $allowedFileExtensionsResolver = $this->getService(AllowedFileExtensionsResolver::class);
 
         // Act & Assert
-        self::assertSame(
-            ['html', 'xml', 'txt', 'yaml', 'yml'],
+        self::assertEquals(
+            ['yaml', 'yml', 'json', 'xml', 'html', 'txt'],
             array_values($allowedFileExtensionsResolver->resolve())
         );
     }

packages/typo3-fractor/tests/Rules/TYPO3v10/Fluid/config/fractor.php

@@ -6,5 +6,4 @@
 use a9f\Typo3Fractor\TYPO3v10\Fluid\RemoveNoCacheHashAndUseCacheHashAttributeFractor;
 
 return FractorConfiguration::configure()
-    ->import(__DIR__ . '/../../../../../config/application.php')
     ->withRules([RemoveNoCacheHashAndUseCacheHashAttributeFractor::class]);

packages/typo3-fractor/tests/Rules/TYPO3v10/Yaml/EmailFinisherFractor/config/fractor.php

@@ -6,5 +6,4 @@
 use a9f\Typo3Fractor\TYPO3v10\Yaml\EmailFinisherFractor;
 
 return FractorConfiguration::configure()
-    ->import(__DIR__ . '/../../../../../../config/application.php')
     ->withRules([EmailFinisherFractor::class]);

packages/typo3-fractor/tests/Rules/TYPO3v10/Yaml/TranslationFileFractor/config/fractor.php

@@ -6,5 +6,4 @@
 use a9f\Typo3Fractor\TYPO3v10\Yaml\TranslationFileFractor;
 
 return FractorConfiguration::configure()
-    ->import(__DIR__ . '/../../../../../../config/application.php')
     ->withRules([TranslationFileFractor::class]);

packages/typo3-fractor/tests/Rules/TYPO3v12/Fluid/AbstractMessageGetSeverityFluidRector/config/fractor.php

@@ -6,5 +6,4 @@
 use a9f\Typo3Fractor\TYPO3v12\Fluid\AbstractMessageGetSeverityFluidRector;
 
 return FractorConfiguration::configure()
-    ->import(__DIR__ . '/../../../../../../config/application.php')
     ->withRules([AbstractMessageGetSeverityFluidRector::class]);

packages/typo3-fractor/tests/Rules/TYPO3v7/FlexForm/AddRenderTypeToFlexFormFractor/config/fractor.php

@@ -6,5 +6,4 @@
 use a9f\Typo3Fractor\TYPO3v7\FlexForm\AddRenderTypeToFlexFormFractor;
 
 return FractorConfiguration::configure()
-    ->import(__DIR__ . '/../../../../../../config/application.php')
     ->withRules([AddRenderTypeToFlexFormFractor::class]);

phpstan.neon

@@ -8,3 +8,5 @@ parameters:
         - packages/
         - ecs.php
         - rector.php
+    excludePaths:
+        - packages/extension-installer/generated

phpunit.xml

@@ -9,8 +9,4 @@
     <testsuite name="all">
         <directory>packages/**/tests</directory>
     </testsuite>
-    <!-- to differentiate cache directory of EasyCodingStandards in tests -->
-    <php>
-        <env name="TEST_SUFFIX" value="_tests"/>
-    </php>
 </phpunit>

rector.php

@@ -8,6 +8,7 @@
     ->withPhpSets(php82: true)
     ->withPreparedSets(deadCode: true, typeDeclarations: true, earlyReturn: true, strictBooleans: true)
     ->withImportNames(true, true, false, true)
+    ->withSkip([__DIR__ . '/packages/extension-installer/generated'])
     ->withPaths([
         __DIR__ . '/ecs.php',
         __DIR__ . '/packages',

src/Composer/Scripts/FractorPackageInstaller.php

@@ -0,0 +1,53 @@
+<?php
+
+declare(strict_types=1);
+
+namespace a9f\FractorMonorepo\Composer\Scripts;
+
+use a9f\FractorExtensionInstaller\PackagesFileGenerator;
+use Composer\Script\Event;
+use Nette\Utils\FileSystem;
+use Nette\Utils\Json;
+
+final class FractorPackageInstaller
+{
+    public static function generate(Event $event): void
+    {
+        $packagesDirectory = __DIR__ . '/../../../packages/';
+
+        $installedPackages = [];
+
+        if ($handle = opendir($packagesDirectory)) {
+            while ($package = readdir($handle)) {
+                $composerFile = $packagesDirectory . $package . '/composer.json';
+
+                if (! file_exists($composerFile)) {
+                    continue;
+                }
+
+                $composerJsonContent = FileSystem::read($composerFile);
+
+                $composerJson = Json::decode($composerJsonContent, true);
+
+                if (! array_key_exists('type', $composerJson)) {
+                    continue;
+                }
+
+                if ((string) $composerJson['type'] !== 'fractor-extension') {
+                    continue;
+                }
+
+                $installedPackages[(string) $composerJson['name']] = [
+                    'path' => dirname($composerFile),
+                ];
+            }
+
+            closedir($handle);
+        }
+
+        PackagesFileGenerator::write(
+            $installedPackages,
+            __DIR__ . '/../../../packages/extension-installer/generated/InstalledPackages.php'
+        );
+    }
+}