Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean the code in config module #582

Merged
merged 1 commit into from
Jan 8, 2019
Merged

Clean the code in config module #582

merged 1 commit into from
Jan 8, 2019

Conversation

FrankBian
Copy link
Contributor

read the config code and do some cleanup:

  • add @OverRide annotation for the Interface implement, eg: PropertiesListener,BasicDataSourceServiceImpl
  • translate the msg from chinese to english, eg: HealthController
  • format some comment blocks,eg: OpsController

@AliGHRobot
Copy link

@FrankBian Thanks for your contribution. 🍻
Please sign off in each of your commits.

@AliGHRobot
Copy link

We found this is your first time to contribute to nacos, @FrankBian
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/nacos/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

hxy1991
hxy1991 approved these changes Jan 8, 2019
View reviewed changes
Copy link
Collaborator

@hxy1991 hxy1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hxy1991 hxy1991 merged commit f2cb9ce into alibaba:develop Jan 8, 2019
@nacos-bot nacos-bot mentioned this pull request Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hxy1991 hxy1991 hxy1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankBian @AliGHRobot @hxy1991