Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limiter DEFAULT_LIMIT optimization #562

Closed
huangyunbin opened this issue Jan 3, 2019 · 1 comment
Closed

Limiter DEFAULT_LIMIT optimization #562

huangyunbin opened this issue Jan 3, 2019 · 1 comment
Assignees
@hxy1991

Comments

@huangyunbin
Copy link
Contributor

huangyunbin commented Jan 3, 2019 •
edited
Loading 

private static final String DEFAULT_LIMIT = "5";
private static double limit = 5;

String limitTimeStr = System.getProperty("limitTime", DEFAULT_LIMIT);

limit and DEFAULT_LIMIT is same mean,no need use two field.
optimization:

String limitTimeStr = System .getProperty("limitTime", String.valueOf(limit));
huangyunbin pushed a commit to huangyunbin/nacos that referenced this issue Jan 3, 2019
alibaba#562 Limiter DEFAULT_LIMIT optimization
5881214
@xuechaos xuechaos assigned nkorange and hxy1991 and unassigned nkorange Jan 3, 2019
hxy1991 added a commit that referenced this issue Jan 8, 2019
@hxy1991
Merge pull request #563 from huangyunbin/limiter
33e5e47 
#562 Limiter DEFAULT_LIMIT optimization
@hxy1991
Copy link
Collaborator

hxy1991 commented Jan 8, 2019

Merged: PR#563

@hxy1991 hxy1991 closed this as completed Jan 8, 2019
@nacos-bot nacos-bot mentioned this issue Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hxy1991 hxy1991

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huangyunbin @hxy1991 @nkorange