Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix and extend ai log #1576

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

rinfx
Copy link
Collaborator

@rinfx rinfx commented Dec 9, 2024

  • 与callback功能结合使用时,response阶段使用replace body会触发crash,替换为proxywasm.SendHttpResponse可以解决该问题
  • 基于日志扩展机制对 ai_log 字段进行扩展

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.54%. Comparing base (ef31e09) to head (06c486b).
Report is 224 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1576      +/-   ##
==========================================
+ Coverage   35.91%   43.54%   +7.63%     
==========================================
  Files          69       76       +7     
  Lines       11576    12325     +749     
==========================================
+ Hits         4157     5367    +1210     
+ Misses       7104     6624     -480     
- Partials      315      334      +19     

see 69 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit f320200 into alibaba:main Dec 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants