Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resend different messages when one fails #155

Closed
infinity0 opened this issue Jan 2, 2015 · 2 comments
Closed

resend different messages when one fails #155

infinity0 opened this issue Jan 2, 2015 · 2 comments

Comments

@infinity0
Copy link
Contributor

Pond is repeatedly trying to send to a remote server which is offline, meaning that messages further down in the queue aren't being sent.

A good fix would be to try a different message the next time. Another possible fix (which I think should still be secure, but maybe not) would be to have separate queues for each server, so that one server going down doesn't affect others.

Related are #134 and #81. The former would give me a way to workaround the bug; currently my Pond client is effectively disabled for sending messages. >:[

@burdges
Copy link
Contributor

burdges commented Jan 4, 2015

Just submitted pull request #156 to fix this. :)

It'll have the side effect of scrambling your outbox order if your machine is offline, like when you unsleep your laptop, so maybe @agl would prefer that connTrouble() check to see if Tor is working at all.

@burdges
Copy link
Contributor

burdges commented Jan 6, 2015

Now fixed in master so this issue should probably be closed. I still worry that messages should not be reordered if tor or the network is down outright, but hey.

@agl agl closed this as completed Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants