Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-78 - Personalized collaboration carets #79

Merged
merged 1 commit into from
Mar 11, 2024
Merged

GH-78 - Personalized collaboration carets #79

merged 1 commit into from
Mar 11, 2024

Conversation

karlpauls
Copy link
Contributor

@karlpauls karlpauls commented Mar 8, 2024

Description

Individual users get their own caret color and a logged in user only shows up one time in the present indicator.
Anonymous users all have the name Anonymous in their caret which has a different color for each.

Bildschirmfoto 2024-03-08 um 17 34 55

Related Issue

Resolves: #78

Motivation and Context

Right now, all users have the same color for their caret - this makes it hard to see who is doing what. Furthermore, we give anon users a user id which might be confusing. If we combine the two, we can call anon users Anonymous but still have them look different due to their caret color. Finally, at least for logged in users, we should only show them one time in the presents indicator.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Release notes

  • Added personalized caret and flag colors based on Adobe ID
Bildschirmfoto 2024-03-08 um 17 34 55

@karlpauls karlpauls requested a review from auniverseaway March 8, 2024 16:39
Copy link

aem-code-sync bot commented Mar 8, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@karlpauls karlpauls merged commit 723555f into main Mar 11, 2024
3 of 4 checks passed
@karlpauls karlpauls deleted the col branch March 11, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Personalized collaboration carets
2 participants