Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check read permission for config reads #117

Merged
merged 2 commits into from
Feb 20, 2025
Merged

Check read permission for config reads #117

merged 2 commits into from
Feb 20, 2025

Conversation

bosschaert
Copy link
Contributor

Description

Check read permission on config read

How Has This Been Tested?

  • Locally with da-live and da-collab
  • Updated unit test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bosschaert bosschaert requested a review from karlpauls February 11, 2025 14:34
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.86%. Comparing base (aebf3c8) to head (28814dd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
- Coverage   75.88%   75.86%   -0.03%     
==========================================
  Files          39       39              
  Lines        2165     2163       -2     
==========================================
- Hits         1643     1641       -2     
  Misses        522      522              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bosschaert bosschaert merged commit db01e68 into main Feb 20, 2025
5 checks passed
@bosschaert bosschaert deleted the hcfg branch February 20, 2025 09:28
bstopp added a commit that referenced this pull request Feb 20, 2025
bstopp added a commit that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants