Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single bucket using S3 APIs #114

Closed
wants to merge 59 commits into from
Closed

Single bucket using S3 APIs #114

wants to merge 59 commits into from

Conversation

bosschaert
Copy link
Contributor

Description

Implement storage using a single bucket using S3 APIs.

The bucket is normally called da-content but the name can be overridden in the wrangler.toml file.

Related Issue

Fixes: #113

How Has This Been Tested?

Testing is currently in progress.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 56.27907% with 188 lines in your changes missing coverage. Please review.

Project coverage is 76.56%. Comparing base (62ec830) to head (4963444).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/auth.js 28.57% 175 Missing ⚠️
src/storage/bucket/list.js 20.00% 4 Missing ⚠️
src/storage/object/get.js 20.00% 4 Missing ⚠️
src/storage/version/list.js 25.00% 3 Missing ⚠️
src/storage/utils/list.js 85.71% 1 Missing ⚠️
src/storage/version/get.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   77.44%   76.56%   -0.88%     
==========================================
  Files          38       39       +1     
  Lines        1822     2155     +333     
==========================================
+ Hits         1411     1650     +239     
- Misses        411      505      +94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from acl to main February 11, 2025 04:18
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bstopp
Copy link
Contributor

bstopp commented Feb 18, 2025

This is in the adobe-infra branch.

@bstopp bstopp closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single Bucket
3 participants