language_detect:chore - remove redundant code #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusalcantarazup
requested review from
iancardosozup,
lucasbrunozup,
nathanmartinszup and
wiliansilvazup
as code owners
Previously during the walk path, for each path visited, before append the new path on the list of paths we were always checking for duplicate values, which make a redundant operation, since this check can be only be done once. Before return the languages we was checking for duplicate languages (again) and also converting the languages from string to `languages.Language` and checking if their supported, which add another redundant loop on `languages.Values()`, since we can only ignore unknown languages during the parsing. This commit remove this redundant code by checking only once for duplicate languages, and ignoring `languages.Unknown` during parsing/appending to all languages list. Signed-off-by: Matheus Alcantara <[email protected]>
matheusalcantarazup
force-pushed
the
improve-languade-detect
branch
from
f73e342 to
fda3260
Compare
lucasbrunozup
approved these changes
Dec 21, 2021
wiliansilvazup
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously during the walk path, for each path visited, before append
the new path on the list of paths we were always checking for duplicate
values, which make a redundant operation, since this check can be only
be done once. Before return the languages we was checking for duplicate
languages (again) and also converting the languages from string to
languages.Languageand checking if their supported, which add anotherredundant loop on
languages.Values(), since we can only ignore unknownlanguages during the parsing.
This commit remove this redundant code by checking only once for
duplicate languages, and ignoring
languages.Unknownduringparsing/appending to all languages list.
Signed-off-by: Matheus Alcantara [email protected]
- What I did
- How to verify it
- Description for the changelog